fix: grpc-js support for nestjs #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsbrain cool, looks like a good fix! Looks like there are a few minor failures in CI, can you take a look? Then I'll merge. Thanks! |
|
Sure, I'll have a look tomorrow :) |
|
@stephenh Ok I think that should be it. Had to update the snapshots because apparently Google updated their repo references for the timestamp proto so e.g. the old timestamp link now got updated so the old one is broken which made the old snapshots not work anymore ... |
|
@stephenh do we need something else to proceed? |
|
Since nestjs v8 is out now, this would be pretty important. |
stephenh
pushed a commit
that referenced
this pull request
Jul 11, 2021
## [1.82.2](v1.82.1...v1.82.2) (2021-07-11) ### Bug Fixes * grpc-js support for nestjs ([#307](#307)) ([d11c8c2](d11c8c2))
|
🎉 This PR is included in version 1.82.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #306